Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Allow non-optional generation of params with optionalNullParams #582

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat!: Allow non-optional generation of params with optionalNullParams #582

wants to merge 1 commit into from

Conversation

pnappa
Copy link

@pnappa pnappa commented Jun 11, 2024

This feature allows specifying whether nullable params should be generated as optional via the config.

The default behaviour stays the same, so this feature is backwards compatible.

Addresses #556

feat!: Allow non-optional generation of params with optionalNullParams
5256b2e 
This feature allows specifying whether nullable params should be
generated as optional via the config.

The default behaviour stays the same, so this feature is backwards
compatible.
@vercel Vercel
Copy link

vercel bot commented Jun 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pgtyped ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 11, 2024 0:41am

@pnappa
Copy link
Author

pnappa commented Jun 11, 2024

Note: I wasn't able to run the tests locally for some reason - npm install && npm run test failed with:

@pgtyped/runtime: > @pgtyped/[email protected] test
@pgtyped/runtime: > NODE_OPTIONS='--experimental-vm-modules' jest
@pgtyped/runtime:  FAIL  src/preprocessor-ts.test.ts
@pgtyped/runtime:   ● Test suite failed to run
@pgtyped/runtime:     src/preprocessor-ts.test.ts:1:30 - error TS2307: Cannot find module '@pgtyped/parser' or its corresponding type declarations.
@pgtyped/runtime:     1 import { parseTSQuery } from '@pgtyped/parser';
@pgtyped/runtime:                                    ~~~~~~~~~~~~~~~~~
@pgtyped/runtime:  FAIL  src/preprocessor-sql.test.ts
@pgtyped/runtime:   ● Test suite failed to run
@pgtyped/runtime:     src/preprocessor-sql.test.ts:1:61 - error TS2307: Cannot find module '@pgtyped/parser' or its corresponding type declarations.
@pgtyped/runtime:     1 import { queryASTToIR, parseSQLFile as parseSQLQuery } from '@pgtyped/parser';
@pgtyped/runtime:                                                                   ~~~~~~~~~~~~~~~~~
@pgtyped/runtime: Test Suites: 2 failed, 2 total
@pgtyped/runtime: Tests:       0 total
@pgtyped/runtime: Snapshots:   0 total
@pgtyped/runtime: Time:        0.963 s
@pgtyped/runtime: Ran all test suites.
@pgtyped/runtime: npm ERR! Lifecycle script `test` failed with error:
@pgtyped/runtime: npm ERR! Error: command failed
@pgtyped/runtime: npm ERR!   in workspace: @pgtyped/[email protected]
@pgtyped/runtime: npm ERR!   at location: /Users/pnappa/github.com/pnappa/pgtyped/packages/runtime

Any ideas?

@pnappa pnappa mentioned this pull request Jun 11, 2024
Open
@pnappa
Copy link
Author

pnappa commented Aug 28, 2024

Hi @adelsz - is there any chance of getting this merged into mainline? Is there anything you'd like me to do?

Cheers!

@pnappa pnappa mentioned this pull request Aug 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pnappa